Re: Latest Data::Dumper breaks hstore_plperl regression test

On 05/13/2017 11:43 PM, Craig Ringer wrote:
>
>
> On 14 May 2017 11:33, "Robert Haas" <robertmhaas(at)gmail(dot)com
> <mailto:robertmhaas(at)gmail(dot)com>> wrote:
>
> On Sat, May 13, 2017 at 6:22 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us
> <mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us>> wrote:
> > Or at least, that's what I surmise from the fact that buildfarm
> critter
> > caiman has been failing that test for the last day or so, with
> symptoms
> > indicating whitespace changes in Data::Dumper output. Some
> poking into
> > the Fedora repo shows that rawhide updated perl-Data-Dumper from
> 2.161
> > to 2.167 on May 11, so that fits ...
>
> Depending on the precise details of how Data::Dumper prints things
> doesn't seem like a particularly good idea.
>
>
> Surely Test::More::is_deeply is the way to go here.

This isn't a TAP test. It's a standard pg_regress test.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services