Re: Latest Data::Dumper breaks hstore_plperl regression test

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Latest Data::Dumper breaks hstore_plperl regression test
Date: 2017-05-14 04:48:22
Message-ID: 7840.1494737302@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
> On 05/13/2017 11:32 PM, Robert Haas wrote:
>> Depending on the precise details of how Data::Dumper prints things
>> doesn't seem like a particularly good idea.

> I'd be inclined to set $Data::Dumper::Indent to 0 which would suppress
> all indentation, and adjusting the test results accordingly. We already
> set $Data::Dumper::Sortkeys to 1, so there's precedent for controlling
> how it presents data back to us.

Sounds plausible to me.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2017-05-14 04:48:39 Re: Latest Data::Dumper breaks hstore_plperl regression test
Previous Message Robert Haas 2017-05-14 04:23:46 Re: Hash Functions