| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Remove obsolete pg_attrdef.adsrc column |
| Date: | 2018-10-27 10:57:00 |
| Message-ID: | fc63c5be-94b5-1e2b-07a4-aa52be7da545@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 23/10/2018 19:48, Daniel Gustafsson wrote:
>> On 23 Oct 2018, at 15:17, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>>
>> I propose the attached patch to remove the long-unused catalog column
>> pg_attrdef.adsrc.
>
> +1, I ran into a bug in an app as recently as today where adsrc was used
> instead of pg_get_expr().
>
> Patch looks good. I probably would’ve opted for mentioning how to get a human
> readable version on the page, along the lines of the attached version,
Agreed. I have integrated your suggestion.
Also, let's go nuts and remove pg_constraint.consrc as well.
Updated patches attached.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Remove-obsolete-pg_attrdef.adsrc-column.patch | text/plain | 3.8 KB |
| v2-0002-Remove-obsolete-pg_constraint.consrc-column.patch | text/plain | 22.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Antonin Houska | 2018-10-27 11:22:01 | Re: Comment fix and question about dshash.c |
| Previous Message | Andres Freund | 2018-10-27 10:41:38 | Resetting PGPROC atomics in ProcessInit() |