From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Remove obsolete pg_attrdef.adsrc column |
Date: | 2018-10-27 21:19:20 |
Message-ID: | 3A344FC1-C695-478A-BD1A-6ADFA50C6227@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 27 Oct 2018, at 12:57, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>
> On 23/10/2018 19:48, Daniel Gustafsson wrote:
>>> On 23 Oct 2018, at 15:17, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>>>
>>> I propose the attached patch to remove the long-unused catalog column
>>> pg_attrdef.adsrc.
>>
>> +1, I ran into a bug in an app as recently as today where adsrc was used
>> instead of pg_get_expr().
>>
>> Patch looks good. I probably would’ve opted for mentioning how to get a human
>> readable version on the page, along the lines of the attached version,
>
> Agreed. I have integrated your suggestion.
>
> Also, let's go nuts and remove pg_constraint.consrc as well.
No objections from me.
> Updated patches attached.
+1, applies and works as intended.
cheers ./daniel
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Vondra | 2018-10-27 23:01:49 | Re: vacuum fails with "could not open statistics file" "Device or resource busy" |
Previous Message | Daniel Gustafsson | 2018-10-27 21:01:06 | Conflicting option checking in pg_restore |