Re: On login trigger: take three

From: Sergey Shinderuk <s(dot)shinderuk(at)postgrespro(dot)ru>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Ivan Panchenko <wao(at)mail(dot)ru>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, a(dot)sokolov(at)postgrespro(dot)ru
Subject: Re: On login trigger: take three
Date: 2022-09-21 13:29:12
Message-ID: fa1a8256-e0b8-1da7-960c-d745a73e33e6@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 20.09.2022 17:10, Daniel Gustafsson wrote:
>> On 20 Sep 2022, at 15:43, Sergey Shinderuk <s(dot)shinderuk(at)postgrespro(dot)ru> wrote:
>> There is a race around setting and clearing of dathasloginevt.
>
> Thanks for the report! The whole dathasloginevt mechanism is IMO too clunky
> and unelegant to go ahead with, I wouldn't be surprised if there are other bugs
> lurking there.
Indeed.

CREATE DATABASE doesn't copy dathasloginevt from the template database.
ALTER EVENT TRIGGER ... ENABLE doesn't set dathasloginevt.

In both cases triggers are enabled according to \dy output, but don't
fire. The admin may not notice it immediately.

--
Sergey Shinderuk https://postgrespro.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2022-09-21 13:51:02 Re: confirmed_flush_lsn shows LSN of the data that has not yet been received by the logical subscriber.
Previous Message Melih Mutlu 2022-09-21 13:18:43 Re: Mingw task for Cirrus CI