Re: confirmed_flush_lsn shows LSN of the data that has not yet been received by the logical subscriber.

From: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
To: Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: confirmed_flush_lsn shows LSN of the data that has not yet been received by the logical subscriber.
Date: 2022-09-21 13:51:02
Message-ID: CAExHW5uhLMo7M62Q+5N69zUqMbfYypA6=ZT_o25napgoNgVgkg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Sep 19, 2022 at 8:09 PM Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> wrote:
>
> On Mon, Sep 19, 2022 at 5:24 PM Ashutosh Bapat
> <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> wrote:
> >
> > On Mon, Sep 19, 2022 at 1:43 PM Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> wrote:
> > >
> > > On Fri, Sep 9, 2022 at 5:36 PM Ashutosh Bapat
> > > <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> wrote:
> > > >
> > > > On Thu, Sep 8, 2022 at 8:32 PM Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> wrote:
> > > > >
> > > > > On Thu, Sep 8, 2022 at 6:23 PM Ashutosh Bapat
> > > > > <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> wrote:
> > > > > >
> > > > > > On Thu, Sep 8, 2022 at 4:14 PM Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> wrote:
> > > > Can you please point to the documentation.
> > > >
> > >
> > > AFAIU there is just one documentation. Here is the link for it:
> > >
> > > https://www.postgresql.org/docs/current/view-pg-replication-slots.html
> >
> > Thanks. Description of confirmed_flush_lsn is "The address (LSN) up to
> > which the logical slot's consumer has confirmed receiving data. Data
> > older than this is not available anymore. NULL for physical slots."
> > The second sentence is misleading. AFAIU, it really should be "Data
> > corresponding to the transactions committed before this LSN is not
> > available anymore". WAL before restart_lsn is likely to be removed but
> > WAL with LSN higher than restart_lsn is preserved. This correction
> > makes more sense because of the third sentence.
> >
>
> Thanks for the clarification. Attached is the patch with the changes.
> Please have a look.
>
Looks good to me. Do you want to track this through commitfest app?

--
Best Wishes,
Ashutosh Bapat

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2022-09-21 14:00:20 Re: Tighten pg_get_object_address argument checking
Previous Message Sergey Shinderuk 2022-09-21 13:29:12 Re: On login trigger: take three