From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: split TOAST support out of postgres.h |
Date: | 2022-12-30 11:53:08 |
Message-ID: | fa03b216-2e81-4fe9-c4fa-bbf3c2058d0b@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 28.12.22 16:07, Tom Lane wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
>> ... Then we could either
>
>> 1) Include varatt.h in postgres.h, similar to elog.h and palloc.h. That
>> way we clean up the files a bit but don't change any external interfaces.
>
>> 2) Just let everyone who needs it include the new file.
>
>> 3) Compromise: You can avoid most "damage" by having fmgr.h include
>> varatt.h. That satisfies most data types and extension code. That way,
>> there are only a few places that need an explicit include of varatt.h.
>
>> I went with the last option in my patch.
>
> I dunno, #3 seems kind of unprincipled. Also, since fmgr.h is included
> so widely, I doubt it is buying very much in terms of reducing header
> footprint. How bad is it to do #2?
See this incremental patch set.
It seems like maybe there is some intermediate abstraction that a lot of
these places should be using that we haven't thought of yet.
Attachment | Content-Type | Size |
---|---|---|
v2-0001-New-header-varatt.h-split-off-from-postgres.h.patch | text/plain | 32.5 KB |
v2-0002-Move-varatt.h-include-to-individual-files.patch | text/plain | 17.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Dean Rasheed | 2022-12-30 12:47:23 | Re: Supporting MERGE on updatable views |
Previous Message | Michael Paquier | 2022-12-30 11:51:15 | Re: Getting rid of SQLValueFunction |