| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Ian Lawrence Barwick <barwick(at)gmail(dot)com> |
| Cc: | Ted Yu <yuzhihong(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Getting rid of SQLValueFunction |
| Date: | 2022-12-30 11:51:15 |
| Message-ID: | Y67Qs7C/ikmnFpD3@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Dec 30, 2022 at 10:57:52AM +0900, Ian Lawrence Barwick wrote:
> I noticed this commit (f193883f) introduces following regressions:
>
> postgres=# SELECT current_timestamp(7);
> WARNING: TIMESTAMP(7) WITH TIME ZONE precision reduced to maximum
> allowed, 6
> ERROR: timestamp(7) precision must be between 0 and 6
>
> postgres=# SELECT localtimestamp(7);
> WARNING: TIMESTAMP(7) precision reduced to maximum allowed, 6
> ERROR: timestamp(7) precision must be between 0 and 6
>
> Suggested fix attached.
The two changes in timestamp.c are fine, Now I can see that the same
mistake was introduced in date.c. The WARNINGs were issued and the
compilation went through the same way as the default, but they passed
down an incorrect precision, so I have fixed all that. Coverage has
been added for all four, while the patch proposed covered only two.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2022-12-30 11:53:08 | Re: split TOAST support out of postgres.h |
| Previous Message | wangw.fnst@fujitsu.com | 2022-12-30 10:25:32 | RE: Perform streaming logical transactions by background workers and parallel apply |