Re: Improve logging when using Huge Pages

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, noriyoshi(dot)shinoda(at)hpe(dot)com, rjuju123(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Improve logging when using Huge Pages
Date: 2021-09-03 16:35:30
Message-ID: f5d8ab35-a44d-2f28-b86f-cd939c1000c4@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021/09/03 23:27, Tom Lane wrote:
> Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> writes:
>> IMO, if the level is promoted to LOG, the message should be updated
>> so that it follows the error message style guide. But I agree that simpler
>> message would be better in this case. So what about something like
>> the following?
>
>> LOG: could not map anonymous shared memory (%zu bytes) with huge pages enabled
>> HINT: The server will map anonymous shared memory again with huge pages disabled.
>
> That is not a hint. Maybe it qualifies as errdetail, though.

Yes, agreed.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2021-09-03 16:54:39 Re: Allow escape in application_name (was: [postgres_fdw] add local pid to fallback_application_name)
Previous Message Daniel Gustafsson 2021-09-03 16:24:04 Re: A reloption for partitioned tables - parallel_workers