Re: Improve logging when using Huge Pages

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, noriyoshi(dot)shinoda(at)hpe(dot)com, rjuju123(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Improve logging when using Huge Pages
Date: 2021-09-03 14:27:13
Message-ID: 2498302.1630679233@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> writes:
> IMO, if the level is promoted to LOG, the message should be updated
> so that it follows the error message style guide. But I agree that simpler
> message would be better in this case. So what about something like
> the following?

> LOG: could not map anonymous shared memory (%zu bytes) with huge pages enabled
> HINT: The server will map anonymous shared memory again with huge pages disabled.

That is not a hint. Maybe it qualifies as errdetail, though.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2021-09-03 14:37:59 Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints
Previous Message Robert Haas 2021-09-03 14:13:53 Re: using an end-of-recovery record in all cases