Re: Adding a note to protocol.sgml regarding CopyData

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, bpd0018(at)gmail(dot)com
Cc: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Adding a note to protocol.sgml regarding CopyData
Date: 2018-09-28 18:16:46
Message-ID: f5947186-5e94-f3af-de3a-27a5b83469a7@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 25/09/2018 13:55, Amit Kapila wrote:
> On Tue, Sep 25, 2018 at 4:51 AM Bradley DeJong <bpd0018(at)gmail(dot)com> wrote:
>>
>> On 2018-09-22, Amit Kapila wrote ...
>> > ... duplicate the same information in different words at three
>> different places ...
>>
>> I count 7 different places. In the protocol docs, there is the old
>> mention in the "Summary of Changes since Protocol 2.0" section
>>
>
> Below text is present in the section quoted by you:
> The special <quote><literal>\.</literal></quote> last line is not
> needed anymore, and is not sent during <command>COPY OUT</command>.
> (It is still recognized as a terminator during <command>COPY
> IN</command>, but its use is deprecated and will eventually be
> removed.)
>
> This email started with the need to mention this in protocol.sgml and
> it is already present although at a different place than the place at
> which it is proposed. Personally, I don't see the need to add it to
> more places. Does anybody else have any opinion on this matter?

Yeah, I don't see why we need to document it three times in the same
chapter.

Also, that chapter is specifically about version 3.0 of the protocol, so
documenting version 2.0 is out of scope.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message James Robinson 2018-09-28 18:30:36 Pithy patch for more detailed error reporting when effective_io_concurrency is set to nonzero on platforms lacking posix_fadvise()
Previous Message Peter Geoghegan 2018-09-28 18:08:07 Re: Making all nbtree entries unique by having heap TIDs participate in comparisons