Pithy patch for more detailed error reporting when effective_io_concurrency is set to nonzero on platforms lacking posix_fadvise()

From: James Robinson <james(at)jlr-photo(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Pithy patch for more detailed error reporting when effective_io_concurrency is set to nonzero on platforms lacking posix_fadvise()
Date: 2018-09-28 18:30:36
Message-ID: A3942987-5BC7-4F05-B54D-2A0EC2914B33@jlr-photo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Per Tom's suggestion on bug #15396, here's a patch to have platforms such as OSX give a more descriptive message when rejecting a nonzero value for effective_io_concurrency.

I had to adjust the GUC's wiring in the #ifndef case so that check_effective_io_concurrency() would be called when a nonzero value is supplied instead of just short-circuiting in parse_and_validate_value() when outside of [conf->min, conf->max].

James

Attachment Content-Type Size
no_fadvise_better_warning_bug_15396.patch application/octet-stream 772 bytes
unknown_filename text/plain 69 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2018-09-28 18:36:19 Re: Use durable_unlink for .ready and .done files for WAL segment removal
Previous Message Peter Eisentraut 2018-09-28 18:16:46 Re: Adding a note to protocol.sgml regarding CopyData