| From: | Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru> |
|---|---|
| To: | Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com> |
| Cc: | Alexander Korotkov <aekorotkov(at)gmail(dot)com>, solaimurugan vellaipandiyan <drsolaimurugan(dot)v(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, g(dot)kashkin(at)postgrespro(dot)ru, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Function scan FDW pushdown |
| Date: | 2026-08-19 14:21:55 |
| Message-ID: | f29ef461267372c23e06ad9ad687f395@postgrespro.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Anthonin Bonnefoy писал(а) 2026-08-19 17:15:
> Hi,
>
> It seems like this patch introduced a compilation warning[0]:
>
> postgres_fdw.c: In function 'postgresExplainForeignScan':
> postgres_fdw.c:3221:36: error: 'relname' may be used uninitialized
> [-Werror=maybe-uninitialized]
> 3221 | if (relname == NULL ||
> strcmp(refname, relname) != 0)
> | ^
> postgres_fdw.c:3132:45: note: 'relname' was declared here
> 3132 | char *relname;
> | ^~~~~~~
>
> Setting relname to NULL during declaration fixes the warning and seems
> to be the expected behavior?
>
> [0]:
> https://github.com/postgres/postgres/actions/runs/32244563943/job/96042498375
>
> Regards,
> Anthonin Bonnefoy
Yes, you are correct. Sorry, missed this fix...
--
Best regards,
Alexander Pyhalov,
Postgres Professional
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2026-08-19 14:31:39 | Re: Function scan FDW pushdown |
| Previous Message | Anthonin Bonnefoy | 2026-08-19 14:15:40 | Re: Function scan FDW pushdown |