Re: Function scan FDW pushdown

From: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
To: Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru>
Cc: Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com>, solaimurugan vellaipandiyan <drsolaimurugan(dot)v(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, g(dot)kashkin(at)postgrespro(dot)ru, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Function scan FDW pushdown
Date: 2026-08-19 14:31:39
Message-ID: CAPpHfduBhNKJySg72qi53+N-jMLyuQeTuqx-FkxDsBVohmO5gQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Aug 19, 2026 at 5:21 PM Alexander Pyhalov
<a(dot)pyhalov(at)postgrespro(dot)ru> wrote:
> Anthonin Bonnefoy писал(а) 2026-08-19 17:15:
> > Hi,
> >
> > It seems like this patch introduced a compilation warning[0]:
> >
> > postgres_fdw.c: In function 'postgresExplainForeignScan':
> > postgres_fdw.c:3221:36: error: 'relname' may be used uninitialized
> > [-Werror=maybe-uninitialized]
> > 3221 | if (relname == NULL ||
> > strcmp(refname, relname) != 0)
> > | ^
> > postgres_fdw.c:3132:45: note: 'relname' was declared here
> > 3132 | char *relname;
> > | ^~~~~~~
> >
> > Setting relname to NULL during declaration fixes the warning and seems
> > to be the expected behavior?
> >
> > [0]:
> > https://github.com/postgres/postgres/actions/runs/32244563943/job/96042498375
> >
> > Regards,
> > Anthonin Bonnefoy
>
> Yes, you are correct. Sorry, missed this fix...

Sorry, I missed that too. Pushed.

------
Regards,
Alexander Korotkov
Supabase

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2026-08-19 15:05:57 Re: hashjoins vs. Bloom filters (yet again)
Previous Message Alexander Pyhalov 2026-08-19 14:21:55 Re: Function scan FDW pushdown