| From: | Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Cc: | Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru>, solaimurugan vellaipandiyan <drsolaimurugan(dot)v(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, g(dot)kashkin(at)postgrespro(dot)ru, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Function scan FDW pushdown |
| Date: | 2026-08-19 14:15:40 |
| Message-ID: | CAO6_XqrGH2NRe0oFx_00nLXra1UZezd3jbS9pgoRhZtgzHD9gg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
It seems like this patch introduced a compilation warning[0]:
postgres_fdw.c: In function 'postgresExplainForeignScan':
postgres_fdw.c:3221:36: error: 'relname' may be used uninitialized
[-Werror=maybe-uninitialized]
3221 | if (relname == NULL ||
strcmp(refname, relname) != 0)
| ^
postgres_fdw.c:3132:45: note: 'relname' was declared here
3132 | char *relname;
| ^~~~~~~
Setting relname to NULL during declaration fixes the warning and seems
to be the expected behavior?
[0]: https://github.com/postgres/postgres/actions/runs/32244563943/job/96042498375
Regards,
Anthonin Bonnefoy
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Fix-compilation-warning-after-0ee83dd4.patch | application/octet-stream | 795 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Pyhalov | 2026-08-19 14:21:55 | Re: Function scan FDW pushdown |
| Previous Message | Andres Freund | 2026-08-19 13:49:17 | Re: SSI: ON CONFLICT DO SELECT takes no predicate lock on the returned row |