Re: multi-install PostgresNode

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: multi-install PostgresNode
Date: 2021-01-28 15:19:57
Message-ID: f263f31b-bff2-b456-e253-0292691c096c@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 1/28/21 9:24 AM, Alvaro Herrera wrote:
> On 2021-Jan-28, Andrew Dunstan wrote:
>
> ... neat stuff, thanks.
>
>> + # Windows picks up DLLs from the PATH rather than *LD_LIBRARY_PATH
>> + # choose the right path separator
>> + if ($Config{osname} eq 'MSWin32')
>> + {
>> + $ENV{PATH} = "$inst/bin;$inst/lib;$ENV{PATH}";
>> + }
>> + else
>> + {
>> + $ENV{PATH} = "$inst/bin:$inst/lib:$ENV{PATH}";
>> + }
> Hmm, if only Windows needs lib/ in PATH, then we do we add $inst/lib to
> PATH even when not Windows?

We could, but there's no point AFAICS. *nix dynamic loaders don't use
the PATH on any platform to my knowledge. This is mainly so that Windows
will find libpq.dll correctly.

>
>> + if (exists $ENV{DYLIB})
>> + {
>> + $ENV{DYLIB} = "$inst/lib:$ENV{DYLIB}";
>> + }
>> + else
>> + {
>> + $ENV{DYLIB} = "$inst/lib}";
> Note extra closing } in the string here.

Oops. fixed, thanks

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Attachment Content-Type Size
PostgresNodePath-2.patch text/x-patch 4.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2021-01-28 15:55:00 Re: strange error reporting
Previous Message Justin Pryzby 2021-01-28 14:30:14 Re: CREATE INDEX CONCURRENTLY on partitioned index