| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: strange error reporting |
| Date: | 2021-01-28 15:55:00 |
| Message-ID: | 20210128155500.GA3440@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-Jan-26, Tom Lane wrote:
> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > pgbench has one occurrence of the old pattern in master, in line 6043.
> > However, since doConnect() returns NULL when it gets CONNECTION_BAD,
> > that seems dead code. This patch kills it.
>
> Oh ... I missed that because it wasn't adjacent to the PQconnectdbParams
> call :-(. You're right, that's dead code and we should just delete it.
Pushed, thanks.
--
Álvaro Herrera 39°49'30"S 73°17'W
"Pensar que el espectro que vemos es ilusorio no lo despoja de espanto,
sólo le suma el nuevo terror de la locura" (Perelandra, C.S.Lewis)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmitry Dolgov | 2021-01-28 16:07:51 | Re: Index Skip Scan (new UniqueKeys) |
| Previous Message | Andrew Dunstan | 2021-01-28 15:19:57 | Re: multi-install PostgresNode |