Re: multi-install PostgresNode

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: multi-install PostgresNode
Date: 2021-03-23 22:36:22
Message-ID: YFptZuWpJ16w3Kw0@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jan 28, 2021 at 10:19:57AM -0500, Andrew Dunstan wrote:
> +BEGIN
> +{
> +
> + # putting this in a BEGIN block means it's run and checked by perl -c
> +
> +
> + # everything other than info and get_new_node that we need to override.
> + # they are all instance methods, so we can use the same template for all.
> + my @instance_overrides = qw(init backup start kill9 stop reload restart
> + promote logrotate safe_psql psql background_psql
> + interactive_psql poll_query_until command_ok
> + command_fails command_like command_checks_all
> + issues_sql_like run_log pg_recvlogical_upto
> + );

No actual objections here, but it would be easy to miss the addition
of a new routine. Would an exclusion filter be more adapted, aka
override everything except get_new_node() and info()?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Zhihong Yu 2021-03-23 22:45:36 Re: Add client connection check during the execution of the query
Previous Message Fabrízio de Royes Mello 2021-03-23 22:05:41 Re: Minimal logical decoding on standbys