code cleanup for SearchSysCache

From: "Qingqing Zhou" <zhouqq(at)cs(dot)toronto(dot)edu>
To: pgsql-hackers(at)postgresql(dot)org
Subject: code cleanup for SearchSysCache
Date: 2006-06-08 05:12:16
Message-ID: e68bjv$i87$1@news.hub.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

There are roughly 420 calls of SearchSysCache() and 217 of which are just
report "cache lookup failed". Shall we put the elog in the SearchSysCache
itself?

Notice that most search is on the "Oid" field -- which is *not* user
visible, so I think most of them can safely let SearchSysCache handle the
failed search without reporting any misleading information. Also, to support
situations where indeed need to check the return tuple, we can add a boolean
parameter "isComplain" to the argument list.

Regards,
Qingqing

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Koichi Suzuki 2006-06-08 05:31:53 Re: How to avoid transaction ID wrap
Previous Message Tom Lane 2006-06-08 03:17:57 Re: sort_mem logging when exceeded ...