Skip site navigation (1) Skip section navigation (2)

Re: code cleanup for SearchSysCache

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Qingqing Zhou" <zhouqq(at)cs(dot)toronto(dot)edu>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: code cleanup for SearchSysCache
Date: 2006-06-08 15:01:01
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
"Qingqing Zhou" <zhouqq(at)cs(dot)toronto(dot)edu> writes:
> There are roughly 420 calls of SearchSysCache() and 217 of which are just
> report "cache lookup failed". Shall we put the elog in the SearchSysCache
> itself?

You'd need two essentially equivalent versions of SearchSysCache, and
you'd lose the ability to make the error message identify what was being
searched for, so I vote no.

			regards, tom lane

In response to


pgsql-hackers by date

Next:From: Bruce MomjianDate: 2006-06-08 15:08:05
Subject: Removing unreferenced files
Previous:From: Joshua D. DrakeDate: 2006-06-08 14:59:42
Subject: Re: How to avoid transaction ID wrap

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group