Re: GUC time unit spelling a bit inconsistent

From: "Marko Kreen" <markokr(at)gmail(dot)com>
To: "Peter Eisentraut" <peter_e(at)gmx(dot)net>
Cc: "Gregory Stark" <stark(at)enterprisedb(dot)com>, "Bruce Momjian" <bruce(at)momjian(dot)us>, "Simon Riggs" <simon(at)2ndquadrant(dot)com>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: GUC time unit spelling a bit inconsistent
Date: 2007-06-21 13:22:29
Message-ID: e51f66da0706210622l4ac1f61fjc8d0840cf2aa1916@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 6/21/07, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> Am Donnerstag, 21. Juni 2007 00:38 schrieb Gregory Stark:
> > > I think people are worried that an 'm' in one column might mean something
> > > different than an 'm' in another column, and perhaps that is confusing.
> >
> > To whom? the person writing it?
>
> If everyone around here had gotten their way we'd already be in a situation
> were you could write
>
> log_rotation_age = 5m
> log_rotation_size = 5m
>
> And someone trained in the metric system would think, "What, five meters?".
> So it rotates when age and size are the same or what? And the ultimate
> consequence of that thinking is that the PostgreSQL developers are uneducated
> dummies and clearly PostgreSQL cannot be a quality product if they can't even
> get that right.
>
> So by all means add documentation and hints.

Considering Postgres will never user either "meter" or "mile"
in settings, I don't consider your argument valid.

I don't see the value of having units globally unique (literally).
It's enough if they unique in the context of postgresql.conf.

Thus +1 of having additional shortcuts Tom suggested.
Also +1 for having them case-insensitive.

--
marko

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paesold 2007-06-21 13:24:51 Re: GUC time unit spelling a bit inconsistent
Previous Message Andrew Dunstan 2007-06-21 13:12:20 Re: GUC time unit spelling a bit inconsistent