Re: Change comment in `contrib/amcheck` regression suite.

From: Andreas Karlsson <andreas(at)proxel(dot)se>
To: Kirill Reshke <reshkekirill(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Change comment in `contrib/amcheck` regression suite.
Date: 2026-01-14 06:06:20
Message-ID: dbbef610-45ab-42f4-bffb-85ceb63e4c2c@proxel.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 12/6/25 12:53 PM, Kirill Reshke wrote:
> I did find a misleading comment in amcheck's regression test suite,
> during un-related hacking in Cloudberry[0]. There is a comment which
> says `-- Check that sequences are rejected` but those are supported
> starting c3b011d
>
> Lets make things not misleading.

I think we should change a bit more to make it more like the tests for
heap tables. What do you think?

Andreas

Attachment Content-Type Size
0001-Improve-amcheck-heap-tests-for-sequences.patch text/x-patch 3.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message jian he 2026-01-14 06:15:04 Re: JumbleQuery ma treat different GROUP BY expr as the same
Previous Message Andreas Karlsson 2026-01-14 05:36:48 Re: [PATCH] test_aio: Skip io_uring tests when kernel disables it