Re: [PATCH] test_aio: Skip io_uring tests when kernel disables it

From: Andreas Karlsson <andreas(at)proxel(dot)se>
To: assam258(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Andres Freund <andres(at)anarazel(dot)de>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
Subject: Re: [PATCH] test_aio: Skip io_uring tests when kernel disables it
Date: 2026-01-14 05:36:48
Message-ID: fe76d2e0-dfb1-4e99-b70b-387bdf8dc4e3@proxel.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 12/8/25 3:12 AM, Henson Choi wrote:
> The patch is minimal (adds one function, modifies one condition) and
> follows the existing pattern used for injection points testing.
>
> Thoughts?

I feel this patch is also related to the the current proposed patch[1]
for giving a proper error on kernel versions older than 5.6. If we
actually want to automatically skip tests if we cannot run io_uring on a
machine it feels more important to skip them on a kernel which does not
support all io_uring ops that we need.

I have not yet made up my mind about automatic skipping when we lack
permissions. Automatically skipping tests can hide issues since you may
not even notice that it happened. Maybe we should call skip if we lack
permissions so it is visible?

1.
https://www.postgresql.org/message-id/17879f12-609b-4730-bfff-6dd11a46d5e6%40gmail.com

Andreas

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andreas Karlsson 2026-01-14 06:06:20 Re: Change comment in `contrib/amcheck` regression suite.
Previous Message Laurenz Albe 2026-01-14 05:24:56 Re: oid2name : add objects file path