| From: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
|---|---|
| To: | Andreas Karlsson <andreas(at)proxel(dot)se> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Change comment in `contrib/amcheck` regression suite. |
| Date: | 2026-01-14 08:53:08 |
| Message-ID: | CALdSSPhAcQBDDZSJUT74jNrt659tsFSFwkcdAssc_oQBJ6GJ7g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 14 Jan 2026 at 11:06, Andreas Karlsson <andreas(at)proxel(dot)se> wrote:
>
> On 12/6/25 12:53 PM, Kirill Reshke wrote:
> > I did find a misleading comment in amcheck's regression test suite,
> > during un-related hacking in Cloudberry[0]. There is a comment which
> > says `-- Check that sequences are rejected` but those are supported
> > starting c3b011d
> >
> > Lets make things not misleading.
>
> I think we should change a bit more to make it more like the tests for
> heap tables. What do you think?
>
> Andreas
Well, additional tests are good, but I did not get why cleanup is
needed (how it worked before?). We don't create anything new in your
patch, but for some reason need to drop..
--
Best regards,
Kirill Reshke
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Anthonin Bonnefoy | 2026-01-14 08:56:07 | Re: Stmt timeout error can be sent after a CommandComplete |
| Previous Message | Andreas Karlsson | 2026-01-14 08:50:47 | Re: [RFC] SLIM Data Type - Compact JSON Alternative (17-62% smaller) |