| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "'pgsql-hackers(at)lists(dot)postgresql(dot)org'" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Missing program_XXX calling in pgbench tests |
| Date: | 2025-06-05 01:50:36 |
| Message-ID: | db4feff7-a294-4a37-87f9-dff5ebbb7324@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2025/06/05 10:18, Hayato Kuroda (Fujitsu) wrote:
> Dear hackers,
>
> While reviewing another thread I found #SUBJECT.
>
> Most of client program executes program_help_ok, program_version_ok,
> program_options_handling_ok() in their test, but pgbench does not do. Instead
> pgbench has own tests for --help and --version options.
>
> One concern is that program_help_ok() checks whether lines are too long or not.
> For now, the rule seems to be kept but not sure in future.
>
> I feel that we can replace tests with common function, like attached. How do you
> think?
+1
A bit similar discussion came up before regarding pgbench and program_xxx_ok
in [1], but it seems that change was never applied.
Regards,
[1] https://postgr.es/m/20180723033518.GG2854@paquier.xyz
--
Fujii Masao
NTT DATA Japan Corporation
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhijie Hou (Fujitsu) | 2025-06-05 02:08:51 | RE: Conflict detection for update_deleted in logical replication |
| Previous Message | Sami Imseih | 2025-06-05 01:44:12 | Re: queryId constant squashing does not support prepared statements |