From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
---|---|
To: | "'pgsql-hackers(at)lists(dot)postgresql(dot)org'" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Missing program_XXX calling in pgbench tests |
Date: | 2025-06-05 01:18:54 |
Message-ID: | OSCPR01MB14966247015B7E3D8D340D022F56FA@OSCPR01MB14966.jpnprd01.prod.outlook.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Dear hackers,
While reviewing another thread I found #SUBJECT.
Most of client program executes program_help_ok, program_version_ok,
program_options_handling_ok() in their test, but pgbench does not do. Instead
pgbench has own tests for --help and --version options.
One concern is that program_help_ok() checks whether lines are too long or not.
For now, the rule seems to be kept but not sure in future.
I feel that we can replace tests with common function, like attached. How do you
think?
Best regards,
Hayato Kuroda
FUJITSU LIMITED
Attachment | Content-Type | Size |
---|---|---|
0001-pgbench-Run-program_XXX-tests-instead-of-its-own-tes.patch | application/octet-stream | 1.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2025-06-05 01:20:09 | Re: a couple of small cleanup patches for DSM-related code |
Previous Message | Yugo Nagata | 2025-06-05 01:08:35 | psql: tab-completion support for COPY ... TO/FROM STDIN, STDOUT, and PROGRAM |