| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Fujii Masao' <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | "'pgsql-hackers(at)lists(dot)postgresql(dot)org'" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Missing program_XXX calling in pgbench tests |
| Date: | 2025-06-05 03:00:26 |
| Message-ID: | OSCPR01MB14966AF5256A5D44E64DC9FB7F56FA@OSCPR01MB14966.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Fujii-san,
> A bit similar discussion came up before regarding pgbench and program_xxx_ok
> in [1], but it seems that change was never applied.
I didn't know that, thanks for sharing. ISTM, it tried to extend function to test the
shorter options.
While verifying the idea, I found that pg_config and pg_bsd_indent have not been
supported "-V" option yet. They must address the option ro improve test functions.
Attached patch set implemented the idea. 0001 is my original point and can be
backported. 0002-0004 needs API changes so they aim to be applied for HEAD.
If possible, I want to fork another thread to discuss 0002-0004 and want to
concentrate 0001 here.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-pgbench-Run-program_XXX-tests-instead-of-its-own-.patch | application/octet-stream | 1.1 KB |
| v2-0002-pg_config-add-V-option.patch | application/octet-stream | 660 bytes |
| v2-0003-pg_bsd_indent-add-V-option.patch | application/octet-stream | 799 bytes |
| v2-0004-Allow-program_XXX_ok-functions-to-test-short-opti.patch | application/octet-stream | 2.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2025-06-05 04:22:40 | Re: Add SPLIT PARTITION/MERGE PARTITIONS commands |
| Previous Message | torikoshia | 2025-06-05 02:15:40 | Re: expand on_error ignore error handling scope |