Re: [HACKERS] wrong t_bits alignment in pageinspect

From: Maksim Milyutin <milyutinma(at)gmail(dot)com>
To: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] wrong t_bits alignment in pageinspect
Date: 2018-01-04 18:06:09
Message-ID: da8b621a-ebbd-4fe6-c436-130cc8beb0a0@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi!

02.01.2018 12:33, Andrey Borodin wrote:
>> 15 дек. 2017 г., в 18:53, Maksim Milyutin <milyutinma(at)gmail(dot)com> написал(а):
>>
>> I found out the problem in exposing values of t_bits field from heap_page_items function.
> Probably, this [0] place contains similar bug too?
>
> [0] https://github.com/postgres/postgres/blob/master/contrib/pageinspect/heapfuncs.c#L439

Yes, it's so. Thanks a lot for notice.

Attached a new version of patch with regression test.

--
Regards,
Maksim Milyutin

Attachment Content-Type Size
pageinspect_tbits_alignment_fix_v2.patch text/plain 3.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2018-01-04 18:08:25 Re: Announcing Release 6 of PostgreSQL Buildfarm client
Previous Message Robert Haas 2018-01-04 17:59:04 Re: explain analyze output with parallel workers - question about meaning of information for explain.depesz.com