Re: [HACKERS] wrong t_bits alignment in pageinspect

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: Maksim Milyutin <milyutinma(at)gmail(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] wrong t_bits alignment in pageinspect
Date: 2018-01-02 09:33:57
Message-ID: 9B8647CA-7097-4A8C-9721-6DFAEE93D6AA@yandex-team.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi!
> 15 дек. 2017 г., в 18:53, Maksim Milyutin <milyutinma(at)gmail(dot)com> написал(а):
>
> I found out the problem in exposing values of t_bits field from heap_page_items function.

Probably, this [0] place contains similar bug too?
Also, may be macro HeapTupleHeaderGetNatts() will be a little bit easier to read.

Best regards, Andrey Borodin.

[0] https://github.com/postgres/postgres/blob/master/contrib/pageinspect/heapfuncs.c#L439

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Rushabh Lathia 2018-01-02 09:38:14 Re: [HACKERS] Parallel tuplesort (for parallel B-Tree index creation)
Previous Message Jeevan Chalke 2018-01-02 08:13:32 Re: [HACKERS] Partition-wise aggregation/grouping