| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de>, Edmund Horner <ejrh00(at)gmail(dot)com> |
| Cc: | Brandur Leach <brandur(at)mutelight(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: Patch for SortSupport implementation on inet/cdir |
| Date: | 2019-03-05 12:36:44 |
| Message-ID: | d77a6d50-fef7-4908-a9eb-86b5233872ab@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2/16/19 4:13 AM, Andres Freund wrote:
> On 2019-02-09 20:12:53 +1300, Edmund Horner wrote:
>> I had a look at this. Your V2 patch applies cleanly, and the code was
>> straightforward and well commented. I appreciate the big comment at the
>> top of network_abbrev_convert explaining how you encode the data.
>
> I've marked the CF entry as waiting-on-author, due to this review.
>
> Brandur, unfortunately this patch has only been submitted to the last
> commitfest for v12. Our policy is that all nontrivial patches should be
> submitted to at least one earlier commitfest. Therefore I unfortunately
> think that v12 is not a realistic target, sorry :(
I agree, and since there has been no response from the author I have
pushed the target version to PG13.
Regards,
--
-David
david(at)pgmasters(dot)net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chris Travers | 2019-03-05 12:47:54 | Re: Prevent extension creation in temporary schemas |
| Previous Message | Heikki Linnakangas | 2019-03-05 11:37:08 | Re: Making all nbtree entries unique by having heap TIDs participate in comparisons |