From: | Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at> |
---|---|
To: | jian he <jian(dot)universality(at)gmail(dot)com> |
Cc: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: doc: create table improvements |
Date: | 2025-10-16 13:19:32 |
Message-ID: | cbc03892163dbf67980e2863b784745517a516a5.camel@cybertec.at |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, 2025-10-16 at 11:28 +0800, jian he wrote:
> -<phrase>where <replaceable
> class="parameter">column_constraint</replaceable> is:</phrase>
> +<phrase>where <replaceable>persistence_mode</replaceable> is: </phrase>
> +
> +[ GLOBAL | LOCAL ] { TEMPORARY | TEMP } |
> +UNLOGGED
>
> we can just do it with one line:
> [ GLOBAL | LOCAL ] { TEMPORARY | TEMP } | UNLOGGED
You are right; changed.
> most of the time, the patch using:
> <replaceable>persistence_mode</replaceable>
> <replaceable>oversize_storage</replaceable>
>
> for column_constraint we are using
> <replaceable class="parameter">column_constraint</replaceable>
>
> do we need change it to
> <replaceable class="parameter">persistence_mode</replaceable>
> <replaceable class="parameter">oversize_storage</replaceable>
> ?
>
> I don't know the purpose of this extra ``"class="parameter"``.
I don't know either. I guess it makes no visible difference.
Anyway, I had a try to establish some consistency in using that
attribute, but had to give up. There is no rhyme and reason for
me. All I did was label <replaceable>parent_table</replaceable>
and <replaceable>source_table</replaceable> with class="parameter",
since that seemed appropriate.
I left the rest alone, any massive changes in that area would make
the patch rather noisy.
Attached is version 3.
Yours,
Laurenz Albe
Attachment | Content-Type | Size |
---|---|---|
v3-0001-Unclutter-CREATE-TABLE-synopsis.patch | text/x-patch | 5.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2025-10-16 13:36:18 | Re: doc: create table improvements |
Previous Message | Akshay Joshi | 2025-10-16 12:50:50 | Re: [PATCH] Add pg_get_policy_ddl() function to reconstruct CREATE POLICY statement |