| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Philip Alger <paalger0(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add pg_get_policy_ddl() function to reconstruct CREATE POLICY statement |
| Date: | 2025-10-16 12:50:50 |
| Message-ID: | CANxoLDcGLSHDj8Ve0qyM2UWMdgSFJA-28j7dEAtMBey8D_ktdA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Please find attached the v3 patch, which resolves all compilation errors
and warnings.
On Thu, Oct 16, 2025 at 6:06 PM Philip Alger <paalger0(at)gmail(dot)com> wrote:
> Hi Akshay,
>
>
>>>> As for the statement terminator, it’s useful to include it, while
>>> running multiple queries together could result in a syntax error. In my
>>> opinion, there’s no harm in providing the statement terminator.
>>>
>> However, I’ve modified the logic to add the statement terminator at the
>> end instead of appending to a new line.
>>
>>>
>>>
> Regarding putting the terminator at the end, I think my original comment
> got cut off by my poor editing. Yes, that's what I was referring to; no
> need to append it to a new line.
>
> --
> Best, Phil Alger
>
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Add-pg_get_policy_ddl-function-to-reconstruct-CREATE.patch | application/octet-stream | 23.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Laurenz Albe | 2025-10-16 13:19:32 | Re: doc: create table improvements |
| Previous Message | Philip Alger | 2025-10-16 12:38:55 | Re: [PATCH] Add pg_get_trigger_ddl() to retrieve the CREATE TRIGGER statement |