| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, akapila(at)postgresql(dot)org, nisha(dot)moond412(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: REASSIGN OWNED vs. relisshared dep on !relisshared |
| Date: | 2026-07-18 16:41:43 |
| Message-ID: | caf6db8912bf1e9e5dad7c047bb74ea254814d77.camel@j-davis.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, 2026-07-18 at 12:10 +0530, Amit Kapila wrote:
> On Thu, Jul 16, 2026 at 12:06 AM Jeff Davis <pgsql(at)j-davis(dot)com>
> > Looks good to me, thank you for the patch. I will commit this soon.
Committed with a smaller test. Thank you.
> > To address Noah's concern: is the concern about the dependency
> > link, or
> > about having a database-specific oid in a shared catalog at all?
...
> I feel it is the latter as the former doesn't scale well, since each
> new db-specific column would need its own bespoke handling instead of
> the dependency machinery handling it uniformly. I agree with your
> judgement that it is not a good idea to tackle this in v19,
> especially
> because splitting a shared, user-visible catalog is too
> invasive to land safely this late in the cycle, whereas the
> subdbid-scoping fix already resolves the actual bug at low risk,
> leaving the decomposition as a structural cleanup better suited to
> v20.
OK, should we go ahead and split the pg_subscription catalog for v20
then? Maybe pg_subscription (shared) and pg_subscription_db (per-
database)?
Regards,
Jeff Davis
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2026-07-18 16:47:23 | Re: pg_plan_advice: fix parsing underscore in numbers |
| Previous Message | Andres Freund | 2026-07-18 16:38:33 | CI slowdown due to PG_TEST_INITDB_EXTRA_OPTS |