| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, akapila(at)postgresql(dot)org, nisha(dot)moond412(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: REASSIGN OWNED vs. relisshared dep on !relisshared |
| Date: | 2026-07-19 01:39:13 |
| Message-ID: | CAA4eK1KHLw61xc4VnLpiq9gDK3mg90cA5izqL5rs3PuuoWw9rg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jul 18, 2026 at 10:11 PM Jeff Davis <pgsql(at)j-davis(dot)com> wrote:
>
> On Sat, 2026-07-18 at 12:10 +0530, Amit Kapila wrote:
> > On Thu, Jul 16, 2026 at 12:06 AM Jeff Davis <pgsql(at)j-davis(dot)com>
> > > Looks good to me, thank you for the patch. I will commit this soon.
>
> Committed with a smaller test. Thank you.
>
> > > To address Noah's concern: is the concern about the dependency
> > > link, or
> > > about having a database-specific oid in a shared catalog at all?
> ...
> > I feel it is the latter as the former doesn't scale well, since each
> > new db-specific column would need its own bespoke handling instead of
> > the dependency machinery handling it uniformly. I agree with your
> > judgement that it is not a good idea to tackle this in v19,
> > especially
> > because splitting a shared, user-visible catalog is too
> > invasive to land safely this late in the cycle, whereas the
> > subdbid-scoping fix already resolves the actual bug at low risk,
> > leaving the decomposition as a structural cleanup better suited to
> > v20.
>
> OK, should we go ahead and split the pg_subscription catalog for v20
> then? Maybe pg_subscription (shared) and pg_subscription_db (per-
> database)?
>
+1, though I am not sure of catalog names. We can brainstorm those
during development.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuo Ishii | 2026-07-19 01:55:13 | Re: Fix duplicate detection for null-treatment window functions |
| Previous Message | Bruce Momjian | 2026-07-19 00:50:24 | Re: First draft of PG 19 release notes |