Re: pg_plan_advice: fix parsing underscore in numbers

> On 18 Jul 2026, at 03:04, Lukas Fittl <lukas(at)fittl(dot)com> wrote:
> On Fri, Jul 17, 2026 at 1:59 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>>> On Jul 17, 2026, at 18:16, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:

>>>> The attached patch fixes this by using pg_strtoint32_safe() in the same way as the core scanner.
>
> FWIW, I've raised this issue at the time during patch review, and
> Robert noted "OK" at the time, but I assume this was forgotten in the
> final committed version.

Considering the size and complexity of the patchset I am not the least bit
surprised, it's easy to lose track of all the things needing to be fixed,
happens to the best of us. Thanks for the reference to the thread though,
clearly both you and Chao Li should get credited with reporting the bug.

>> PFA v3, which only adds this test case.
>
> I think v3 looks good from a quick look.

Thanks for the updated patch and the review of that version, I'll have a closer
look at it later tonight.

--
Daniel Gustafsson