| From: | "Euler Taveira" <euler(at)eulerto(dot)com> |
|---|---|
| To: | "Amit Kapila" <amit(dot)kapila16(at)gmail(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Cc: | "Arunprasad Rajkumar" <ar(dot)arunprasad(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Skip unpublishable child tables when adding parent to publication |
| Date: | 2025-12-16 23:12:34 |
| Message-ID: | ca016f88-5d66-42b0-aae8-84d540352fff@app.fastmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Dec 16, 2025, at 6:34 AM, Amit Kapila wrote:
>
> Prohibiting all commands sounds too restrictive in all cases (FOR ALL
> TABLES, FOR TABLE, etc.). It would be better if we can disallow
> creating a publication when the user explicitly adds such a relation
> in a FOR TABLE publication, otherwise raise a WARNING and don't make
> it part of publication. The behavior should be the same for both
> partition and inherited tables.
>
WFM. The attached patch checks the partitions too. The behavior is similar to
inherited tables. However, I didn't understand the "otherwise" part. Are you
suggesting to add WARNING in the FOR ALL TABLES and FOR TABLES IN SCHEMA if
there is any unsupported relations?
--
Euler Taveira
EDB https://www.enterprisedb.com/
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Fix-unsupported-relations-for-publications.patch | text/x-patch | 7.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2025-12-16 23:49:28 | Re: [Proposal] Adding Log File Capability to pg_createsubscriber |
| Previous Message | Jacob Champion | 2025-12-16 23:09:51 | Re: Custom oauth validator options |