| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Gyan Sreejith <gyan(dot)sreejith(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, vignesh C <vignesh21(at)gmail(dot)com> |
| Subject: | Re: [Proposal] Adding Log File Capability to pg_createsubscriber |
| Date: | 2025-12-16 23:49:28 |
| Message-ID: | CAHut+Pv=aay8MNsisoBwQ2TLQSKOf5XmGapok3yJgE8Z0uz49g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Dec 12, 2025 at 12:33 PM Gyan Sreejith <gyan(dot)sreejith(at)gmail(dot)com> wrote:
>
> Thanks for the feedback, Peter.
>
> I am currently working on the SGML docs update, and will promptly get back with an update.
>
> For your second point, currently, all output goes directly to the console. I thought it made more sense to break it up into multiple files depending on what was being invoked. Do you have another opinion?
>
The point I was trying to make was that if you are going to have a
"--logdir" option, then IMO that option should do nothing other than
change the destination for the logs. In other words, current behaviour
is effectively --logdir=console, so --logdir=some_other_folder should
not have some side-effect causing the log to get split into multiple
files.
If you want to split logs, then I thought Kuroda-San's suggestion [1]
sounded better --- (a) mimic pg_upgrade more closely and (b)
reconsider if -logdir is needed at all.
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-12-17 00:06:35 | Re: [PATCH]Remove the redundant assignment |
| Previous Message | Euler Taveira | 2025-12-16 23:12:34 | Re: [PATCH] Skip unpublishable child tables when adding parent to publication |