Re: [PATCH] Skip unpublishable child tables when adding parent to publication

From: Arunprasad Rajkumar <ar(dot)arunprasad(at)gmail(dot)com>
To: Euler Taveira <euler(at)eulerto(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Skip unpublishable child tables when adding parent to publication
Date: 2025-12-18 17:15:37
Message-ID: CACDxuFymdSvOhTDPR92Wr2YE=3k_ORex2ZiC7wYkisKXhPiUKQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Amit,

There seem to be different interpretations of your comment.

I understood it as suggesting that we should show a WARNING when adding a
partition or parent table that has unsupported descendant tables.

I would greatly appreciate some clarification on this point. Thanks a lot.

Regards,
Arun

On Wed, 17 Dec 2025 at 04:43, Euler Taveira <euler(at)eulerto(dot)com> wrote:

> On Tue, Dec 16, 2025, at 6:34 AM, Amit Kapila wrote:
> >
> > Prohibiting all commands sounds too restrictive in all cases (FOR ALL
> > TABLES, FOR TABLE, etc.). It would be better if we can disallow
> > creating a publication when the user explicitly adds such a relation
> > in a FOR TABLE publication, otherwise raise a WARNING and don't make
> > it part of publication. The behavior should be the same for both
> > partition and inherited tables.
> >
>
> WFM. The attached patch checks the partitions too. The behavior is similar
> to
> inherited tables. However, I didn't understand the "otherwise" part. Are
> you
> suggesting to add WARNING in the FOR ALL TABLES and FOR TABLES IN SCHEMA if
> there is any unsupported relations?
>
>
> --
> Euler Taveira
> EDB https://www.enterprisedb.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2025-12-18 17:20:38 Re: Buffer locking is special (hints, checksums, AIO writes)
Previous Message Jacob Champion 2025-12-18 17:06:19 Re: Serverside SNI support in libpq