Re: Modifying data type of slot_keep_segs from XLogRecPtr to XLogSegNo

From: torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Modifying data type of slot_keep_segs from XLogRecPtr to XLogSegNo
Date: 2020-07-08 02:55:56
Message-ID: c6da1bbab64e80b5126de5be5f36d906@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-07-08 11:15, Fujii Masao wrote:
> On 2020/07/08 11:02, torikoshia wrote:
>> Hi,
>>
>> Currently, slot_keep_segs is defined as "XLogRecPtr" in KeepLogSeg(),
>> but it seems that should be "XLogSegNo" because this variable is
>> segment number.
>>
>> How do you think?
>
> I agree that using XLogRecPtr for slot_keep_segs is incorrect.
> But this variable indicates the number of segments rather than
> segment no, uint64 seems better. Thought?

That makes sense.
The number of segments and segment number are different.

Regards,

--
Atsushi Torikoshi
NTT DATA CORPORATION

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Gilman 2020-07-08 03:19:35 Re: Warn when parallel restoring a custom dump without data offsets
Previous Message Amit Langote 2020-07-08 02:53:00 Re: Performing partition pruning using row value