| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | torikoshia <torikoshia(at)oss(dot)nttdata(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Modifying data type of slot_keep_segs from XLogRecPtr to XLogSegNo |
| Date: | 2020-07-08 06:22:36 |
| Message-ID: | ae4d26f7-63e2-3e51-ec8b-63244563be3b@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020/07/08 11:55, torikoshia wrote:
> On 2020-07-08 11:15, Fujii Masao wrote:
>> On 2020/07/08 11:02, torikoshia wrote:
>>> Hi,
>>>
>>> Currently, slot_keep_segs is defined as "XLogRecPtr" in KeepLogSeg(),
>>> but it seems that should be "XLogSegNo" because this variable is
>>> segment number.
>>>
>>> How do you think?
>>
>> I agree that using XLogRecPtr for slot_keep_segs is incorrect.
>> But this variable indicates the number of segments rather than
>> segment no, uint64 seems better. Thought?
>
> That makes sense.
> The number of segments and segment number are different.
Yes, so patch attached. I will commit it later.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| Attachment | Content-Type | Size |
|---|---|---|
| num_of_wal_segs.patch | text/plain | 506 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2020-07-08 06:26:20 | Re: Collation versioning |
| Previous Message | Fujii Masao | 2020-07-08 06:19:34 | Re: Performing partition pruning using row value |