Re: Modifying data type of slot_keep_segs from XLogRecPtr to XLogSegNo

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Modifying data type of slot_keep_segs from XLogRecPtr to XLogSegNo
Date: 2020-07-08 02:15:48
Message-ID: 8bb8426f-0bc1-1b98-9e2a-ca1c1be25acf@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020/07/08 11:02, torikoshia wrote:
> Hi,
>
> Currently, slot_keep_segs is defined as "XLogRecPtr" in KeepLogSeg(),
> but it seems that should be "XLogSegNo" because this variable is
> segment number.
>
> How do you think?

I agree that using XLogRecPtr for slot_keep_segs is incorrect.
But this variable indicates the number of segments rather than
segment no, uint64 seems better. Thought?

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2020-07-08 02:16:54 Re: posgres 12 bug (partitioned table)
Previous Message movead.li@highgo.ca 2020-07-08 02:11:28 Re: A patch for get origin from commit_ts.