| From: | Adrien Nayrat <adrien(dot)nayrat(at)anayrat(dot)info> |
|---|---|
| To: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Vik Fearing <vik(dot)fearing(at)2ndquadrant(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, <david(dot)rowley(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: New GUC to sample log queries |
| Date: | 2018-11-18 09:52:42 |
| Message-ID: | bbb6d622-c48a-125d-a91e-009c519f4992@anayrat.info |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/18/18 12:47 AM, Dmitry Dolgov wrote:
> This patch went through last few commitfests without any activity, but cfbot
> says it still applies and doesn't break any tests. From what I see there was
> some agreement about naming, so the patch is indeed needs more review. Could
> anyone from the reviewers (Vik?) confirm that it's in a good shape?
Thanks Dmitry to bringing this up.
For me, the question is how to name this GUC?
Is "log_sample_rate" is enough? I am not sure because it is only related to
queries logged by log_min_duration_statements.
Alors, I wonder if we should use the same logic for other parameters, such as
log_statement_stats
log_parser_stats
log_planner_stats
log_executor_stats
It was mentioned in this thread
https://www.postgresql.org/message-id/20180710183828.GB3890%40telsasoft.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Darafei Komяpa Praliaskouski | 2018-11-18 10:12:44 | Re: zheap: a new storage format for PostgreSQL |
| Previous Message | Alexander Lakhin | 2018-11-18 07:30:31 | Re: make installcheck-world in a clean environment |