Re: New GUC to sample log queries

From: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
To: adrien(dot)nayrat(at)anayrat(dot)info
Cc: Vik Fearing <vik(dot)fearing(at)2ndquadrant(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, david(dot)rowley(at)2ndquadrant(dot)com, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: New GUC to sample log queries
Date: 2018-11-18 11:18:33
Message-ID: CA+q6zcVQsqB5thfW9LsJpJ0mWvardiJWBKdvyAdbVFXGxqCxPg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Sun, 18 Nov 2018 at 10:52, Adrien Nayrat <adrien(dot)nayrat(at)anayrat(dot)info>
> wrote:
>
> For me, the question is how to name this GUC? Is "log_sample_rate" is enough?
> I am not sure because it is only related to queries logged by
> log_min_duration_statements.

Since it's hard to come up with a concise name that will mention sampling rate
in the context of min_duration_statement, I think it's fine to name this
configuration "log_sample_rate", as long as it's dependency from
log_min_duration_statements is clearly explained in the documentation.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Shay Rojansky 2018-11-18 16:49:01 [PATCH] Allow UNLISTEN during recovery
Previous Message Fabien COELHO 2018-11-18 10:23:08 Re: [HACKERS] pgbench - allow to store select results into variables