| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Nikolay Shaplov <dhyan(at)nataraj(dot)su>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Dent John <denty(at)qqdd(dot)eu>, "Iwata, Aya" <iwata(dot)aya(at)jp(dot)fujitsu(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Add some useful asserts into View Options macroses |
| Date: | 2019-11-01 12:29:58 |
| Message-ID: | bb465aed-06bf-5431-0f3c-f948e167ac80@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-10-08 12:44, Nikolay Shaplov wrote:
> В письме от понедельник, 7 октября 2019 г. 12:59:27 MSK пользователь Robert
> Haas написал:
>
>>> This thread is a follow up to the thread
>>> https://www.postgresql.org/message-id/2620882.s52SJui4ql@x200m where I've
>>> been trying to remove StdRdOptions structure and replace it with unique
>>> structure for each relation kind.
>>>
>>> I've decided to split that patch into smaller parts.
>>>
>>> This part adds some asserts to ViewOptions macroses.
>>> Since an option pointer there is converted into (ViewOptions *) it would
>>> be
>>> really good to make sure that this macros is called in proper context, and
>>> we do the convertation properly. At least when running tests with asserts
>>> turned on.
Committed.
I simplified the parentheses by one level from your patch.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2019-11-01 12:33:32 | Re: pglz performance |
| Previous Message | Adam Lee | 2019-11-01 12:18:02 | Looking for a demo of extensible nodes |