Re: [PATCH] Do not use StdRdOptions in Access Methods

From: Nikolay Shaplov <dhyan(at)nataraj(dot)su>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Dent John <denty(at)qqdd(dot)eu>, "Iwata, Aya" <iwata(dot)aya(at)jp(dot)fujitsu(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
Subject: Re: [PATCH] Do not use StdRdOptions in Access Methods
Date: 2019-10-05 15:12:26
Message-ID: 2620882.s52SJui4ql@x200m
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

В Fri, 27 Sep 2019 17:24:49 +0900
Michael Paquier <michael(at)paquier(dot)xyz> пишет:

> > Looks like some good actionable feedback. I've moved this patch to
> > September, and set it to "Waiting on Author".
> The patch is in this state for two months now, so I have switched it
> to "returned with feedback". The latest patch does not apply, and it
> would require an update for the new test module dummy_index_am.

I've been thinking about this patch and came to a conclusion that it
would be better to split it to even smaller parts, so they can be
easily reviewed, one by one. May be even leaving most complex
Heap/Toast part for later.

This is first part of this patch. Here we give each Access Method it's
own option binary representation instead of StdRdOptions.

I think this change is obvious. Because, first, Access Methods do not
use most of the values defined in StdRdOptions.

Second this patch make Options structure code unified for all core
Access Methods. Before some AM used StdRdOptions, some AM used it's own
structure, now all AM uses own structures and code is written in the
same style, so it would be more easy to update it in future.

John Dent, would you join reviewing this part of the patch? I hope it
will be more easy now...

Software Developer:
Body-oriented Therapist: (Russian)

Attachment Content-Type Size
do-not-use-StdRdOptions-in-AM_1.diff text/x-patch 9.9 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2019-10-05 17:08:38 pgsql: Report test_atomic_ops() failures consistently, via macros.
Previous Message Martín Marqués 2019-10-05 11:43:03 Non-null values of recovery functions after promote or crash of primary