Re: Patch to address creation of PgStat* contexts with null parent context

From: "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, <andres(at)anarazel(dot)de>
Cc: <reid(dot)thompson(at)crunchydata(dot)com>, <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Patch to address creation of PgStat* contexts with null parent context
Date: 2022-09-07 09:11:11
Message-ID: b948b729-42fe-f88c-2f4a-0e65d84c049b@amazon.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 9/6/22 7:53 AM, Kyotaro Horiguchi wrote:
> At Mon, 5 Sep 2022 14:46:55 +0200, "Drouvot, Bertrand"<bdrouvot(at)amazon(dot)com> wrote in
>> Looks like that both approaches have their pros and cons. I'm tempted
>> to vote +1 on "just changing" the parent context to TopMemoryContext
>> and not changing the allocations locations.
> Yeah. It is safe more than anything and we don't have a problem there.
>
> So, I'm fine with just replacing the parent context at the three places.

Attached a patch proposal to do so.

Regards,

--

Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services:https://aws.amazon.com

Attachment Content-Type Size
v1-0001-pgstat_memory_contexts.patch text/plain 1.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2022-09-07 09:11:37 Re: [PATCH] Renumber confusing value for GUC_UNIT_BYTE
Previous Message Justin Pryzby 2022-09-07 09:11:09 Re: [postgis-devel] PostGIS and json_categorize_type (Re: pgsql: Revert SQL/JSON features)