Re: Patch to address creation of PgStat* contexts with null parent context

From: Andres Freund <andres(at)anarazel(dot)de>
To: "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, reid(dot)thompson(at)crunchydata(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Patch to address creation of PgStat* contexts with null parent context
Date: 2022-09-17 16:10:06
Message-ID: 20220917161006.v5b5obop2ojgqiv2@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2022-09-07 11:11:11 +0200, Drouvot, Bertrand wrote:
> On 9/6/22 7:53 AM, Kyotaro Horiguchi wrote:
> > At Mon, 5 Sep 2022 14:46:55 +0200, "Drouvot, Bertrand"<bdrouvot(at)amazon(dot)com> wrote in
> > > Looks like that both approaches have their pros and cons. I'm tempted
> > > to vote +1 on "just changing" the parent context to TopMemoryContext
> > > and not changing the allocations locations.
> > Yeah. It is safe more than anything and we don't have a problem there.
> >
> > So, I'm fine with just replacing the parent context at the three places.
>
> Attached a patch proposal to do so.

Pushed. Thanks for the report and the fix!

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Banck 2022-09-17 16:57:39 Re: [EXTERNAL] Re: Support load balancing in libpq
Previous Message Peter Eisentraut 2022-09-17 09:49:01 Re: archive modules