Re: Tree-walker callbacks vs -Wdeprecated-non-prototype

From: Andres Freund <andres(at)anarazel(dot)de>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Tree-walker callbacks vs -Wdeprecated-non-prototype
Date: 2025-05-22 14:47:06
Message-ID: b7angm4wz2ln2wsqvsb3bwl4pqa4xxgcawn36o5kweu5pgpl6s@ofhhrgl5ouwb
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2022-12-13 14:18:48 +1300, Thomas Munro wrote:
> On Mon, Dec 12, 2022 at 4:43 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > On Mon, Dec 12, 2022 at 4:07 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > > I'm for "turn the warning off". Per previous discussion, adhering
> > > strictly to that rule would make our code worse (less legible AND
> > > less safe), not better.
> >
> > Alright, this seems to do the trick here.
>
> That did fix that problem. But... seawasp also just recompiled its
> compiler and picked up new opaque pointer API changes. So no green
> today. I have more work to do to fix that, which might take some time
> to get back to.

Presumably due to conflict resolution, this commit added an empty meson.build
to REL_13_STABLE. I'll remove that...

Greetings,

Andres Freund

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-05-22 14:51:30 Re: Reduce "Var IS [NOT] NULL" quals during constant folding
Previous Message Nathan Bossart 2025-05-22 14:30:40 Re: Statistics Import and Export