Re: Tree-walker callbacks vs -Wdeprecated-non-prototype

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Tree-walker callbacks vs -Wdeprecated-non-prototype
Date: 2022-12-13 01:18:48
Message-ID: CA+hUKG+F_5qqne+z+dirf5N3hinFsf=7=EygwEynpwq09OcEzQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Dec 12, 2022 at 4:43 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> On Mon, Dec 12, 2022 at 4:07 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > I'm for "turn the warning off". Per previous discussion, adhering
> > strictly to that rule would make our code worse (less legible AND
> > less safe), not better.
>
> Alright, this seems to do the trick here.

That did fix that problem. But... seawasp also just recompiled its
compiler and picked up new opaque pointer API changes. So no green
today. I have more work to do to fix that, which might take some time
to get back to.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2022-12-13 01:23:24 Re: Time delayed LR (WAS Re: logical replication restrictions)
Previous Message Peter Geoghegan 2022-12-13 00:59:58 Re: New strategies for freezing, advancing relfrozenxid early