| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | David Steele <david(at)pgmasters(dot)net>, Sergei Kornilov <sk(at)zsrv(dot)org>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: recovery_target_action=pause with confusing hint |
| Date: | 2020-03-24 06:39:57 |
| Message-ID: | b007be90-572a-f735-8900-75d011afc97f@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020/03/10 2:27, Robert Haas wrote:
> On Mon, Mar 9, 2020 at 12:03 PM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>> I started the discussion about the topic very related to this.
>> I'm thinking to apply the change that Sergei proposes after applying
>> the patch I attached in this thread.
>> https://postgr.es/m/00c194b2-dbbb-2e8a-5b39-13f14048ef0a@oss.nttdata.com
>
> I think it would be good to change the primary message, not just the hint. e.g.
>
> LOG: pausing at end of recovery
> HINT: Execute pg_wal_replay_resume() to promote.
>
> vs.
>
> LOG: recovery has paused
> HINT: Execute pg_wal_replay_resume() to continue.
Looks good to me.
Attached is the updated version of the patch.
This is based on Sergei's patch.
Regards,
--
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters
| Attachment | Content-Type | Size |
|---|---|---|
| recoveryPausesHere_v1.patch | text/plain | 2.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2020-03-24 06:47:43 | Re: Option to dump foreign data in pg_dump |
| Previous Message | Justin Pryzby | 2020-03-24 06:23:26 | Re: weird hash plan cost, starting with pg10 |